TiddlyWiki / TiddlyWiki/TiddlyWiki5

[BUG] Deleting a draft tiddler should not also delete the original tiddler

Open
#4,792 9 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discussion
Dominant language
JavaScript
Stars
8.7k
Forks
1.3k
Avg merge
3d 4h
Merged PRs (30d)
12

Description

Describe the bug
Deleting a draft tiddler also deletes the associated original tiddler.

The original idea was that the delete operation should only be available in edit mode so as to reduce the change of accidental deletions while reading a wiki, and thus the need to delete the original tiddler as well as the draft. However, it turns out that draft tiddlers often get abandoned by users, and need to be cleaned up later. The fact that deleting such drafts also deletes the original tiddler does not match the users expectations.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://tiddlywiki.com/empty.html
  2. Click the "new tiddler" button to create a new tiddler
  3. Type some text in the body of the tiddler
  4. Click the "tick" button to save the tiddler
  5. Click the "edit" button to edit the new tiddler
  6. Click the "delete" button to delete the draft tiddler
  7. Click "OK" on the confirmation alert
  8. Search for "New" to verify that the newly created tiddler has been deleted as well as its draft.

Expected behavior
Deleting a draft tiddler should not delete the associated original tiddler.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior in https://tiddlywiki.com/empty.html using the listed steps, then trace the delete action for a draft tiddler and its associated original. Done means deleting the draft removes only the draft, while the original tiddler remains available.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.