TiddlyDesktop fails to load node JS wiki which has a $:/favicon.ico tiddler

Open
#207 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
desktop

Research direction

Start with $:/core/modules/startup/favicon.js at setFavicon, then inspect the boot sequence shown in boot/boot.js and reproduce opening a Node.js wiki containing a $:/favicon.ico tiddler. Done means TiddlyDesktop opens the wiki without a blank screen and the favicon is handled for both inline and canonical URI cases.

Written by the indexing model from the issue text.

Description

The failure to open the node JS wiki (and leaves a blank screen) is revealed in the DEV console:

Uncaught TypeError: Cannot read property 'setAttribute' of null
    at setFavicon ($:/core/modules/startup/favicon.js:43)
    at Object.exports.startup ($:/core/modules/startup/favicon.js:27)
    at Object.$tw.boot.executeNextStartupTask (/home/sits/TiddlyDesktop-linux64-v0.0.14/tiddlywiki/boot/boot.js:2391)
    at Object.$tw.boot.executeNextStartupTask (/home/sits/TiddlyDesktop-linux64-v0.0.14/tiddlywiki/boot/boot.js:2395)
    at Object.$tw.boot.executeNextStartupTask (/home/sits/TiddlyDesktop-linux64-v0.0.14/tiddlywiki/boot/boot.js:2395)
    at Object.$tw.boot.executeNextStartupTask (/home/sits/TiddlyDesktop-linux64-v0.0.14/tiddlywiki/boot/boot.js:2395)
    at Object.$tw.boot.executeNextStartupTask (/home/sits/TiddlyDesktop-linux64-v0.0.14/tiddlywiki/boot/boot.js:2395)
    at Object.$tw.boot.executeNextStartupTask (/home/sits/TiddlyDesktop-linux64-v0.0.14/tiddlywiki/boot/boot.js:2395)
    at Object.$tw.boot.startup (/home/sits/TiddlyDesktop-linux64-v0.0.14/tiddlywiki/boot/boot.js:2348)
    at /home/sits/TiddlyDesktop-linux64-v0.0.14/tiddlywiki/boot/boot.js:2501

It seems to be on the final faviconLink.setAttribute call as my favicon is stored inline.

function setFavicon() {
	var tiddler = $tw.wiki.getTiddler(FAVICON_TITLE);
	if(tiddler) {
		var faviconLink = document.getElementById("faviconLink");
		if(tiddler.fields._canonical_uri) {
			$:/favicon.ico ("href",tiddler.fields._canonical_uri);
		} else {
			faviconLink.setAttribute("href","data:" + tiddler.fields.type + ";base64," + tiddler.fields.text);			
		}
	}
}

I just drag and dropped the $:/favicon.ico tiddler from the official tiddlywiki.com static site to my node JS wiki. Once I deleted the $:/favicon.ico tiddler TiddlyDesktop could open it successfully.

This is using TiddlyDesktop 0.0.14 on Ubuntu 20.

Dominant language
JavaScript
Stars
1.9k
Forks
136
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from TiddlyWiki/TiddlyDesktop

All issues in TiddlyWiki/TiddlyDesktop

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.