TiddlyWiki / TiddlyWiki/TiddlyDesktop

_canonical_uri issue with Drag and Drop external files on Windows 10

Open
#182 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.9k
Forks
136
PR merge metrics
No merged PRs in 30d

Description

When I drag and drop an image file into a fresh Tiddlywiki (v5.1.21) in TiddlyDesktop on Windows 10 the auto-generated _canonical_uri is incorrect. If I open the tiddler containing the imported image, I received the 'broken-image-link' thumbnail. If I delete a single period from the front of the auto-generated _canonical_uri, the image shortcut is fixed.

Example Directory Structure:
Tiddlywiki.html
|
| -- images\ example.jpg

If I drag and drop "example.jpg" into Tiddlywiki.html in TiddlyDesktop, the auto generated _canonical_uri is currently "../images/example.jpg" (note the leading double periods) and the image is not displayed properly in the resulting tiddler. If I remove a single leading period (to indicate current directory), the image link is corrected and the image is displayed properly. I have tested this on a couple machines and the behavior is the same on both. The auto-generated _canonical_uri is always one directory higher than the actual path of the file is.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the drag-and-drop import in TiddlyDesktop v5.1.21 on Windows 10 using the directory structure and example.jpg described in the report. Trace how the external file path becomes _canonical_uri, then verify that the generated URI points to the actual image location and the imported tiddler displays the image.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.