TiddlyWiki / TiddlyWiki/MultiWikiServer

Recipe ACL in index_json could be optimized

Open
#19 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
60
Forks
16
PR merge metrics
No merged PRs in 30d

Description

There is no OR query on the Recipe, only a check on whether the bag OR passes for every bag.

The bag OR checks the recipe, so every bag created with withACL will check the recipe permission.

So the check is there, but there might be an optimization to check the recipe ACL and withACL before checking the bags.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the index_json entry point and trace how recipe ACL, withACL, and bag permission checks are evaluated. Confirm whether a recipe-level check can precede the bag checks without changing authorization behavior; done means the optimization is implemented and existing permission behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authorization, backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.