TiddlyWiki / TiddlyWiki/MultiWikiServer

Recipe ACL seems to inherit bag ACL setting. IMO that's wrong

Open
#106 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug discussion
Dominant language
TypeScript
Stars
60
Forks
16
PR merge metrics
No merged PRs in 30d

Description

  • I do have 2 users: aaa and bbb
  • aaa creates a bag: bag-a
  • aaa creates a recipe: recipe-a, which lists bag-a ... without any extra settings
  • user aaa sets ACL for bag-a to USER : READ

User bbb logs in

  • User bbb sees the Recipe -> BUG
  • and the bag -> OK

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported steps with users aaa and bbb, then trace how recipe and bag ACLs are checked when bbb lists them. Confirm the fix when bbb cannot see recipe-a while still seeing bag-a, and add or update a regression test if the project has coverage for these ACL checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authorization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.