Thinkmill / Thinkmill/keystatic

Prevent login for people without write access github repo

Open
#831 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

storage:github
Dominant language
TypeScript
Stars
2.4k
Forks
159
Avg merge
21h 41m
Merged PRs (30d)
2

Description

Hey there,

I've been trying to setup Keystatic with a Github repo. It works great until I want new people to contribute. I understand that people need write access to use Keystatic but why allow people to login at all? Right now, people can login but get a cryptic error when they try to edit anything:

image

It seems like keystatic cloud handles this, if I try to login to https://keystatic.com/keystatic I get an expected error message:

image

Could we have something similar for the Github integration?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the GitHub integration's login and permission checks, then compare the behavior described for Keystatic Cloud. Confirm how write access is detected and define the expected message for users without it. Done means those users receive a clear error during login instead of a cryptic error when they try to edit.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, typescript
Domain
authentication, authorization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.