Thinkmill / Thinkmill/keystatic
Switching to password on Keystatic Cloud signup clears `from` query param
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.4k
- Forks
- 159
- Avg merge
- 21h 41m
- Merged PRs (30d)
- 2
Description
When inviting a new user to join a team using Keystatic Cloud, an email is sent with a link to join. This link has a from query param with some team code. Example:
https://keystatic.cloud/team/join/<some_token>
This takes you to a page that says to sign in to join the team with the following link:
https://keystatic.cloud/signin?from=team%2Fjoin%<signup_token>
Here, if the user doesn't have an account they can click the sign up link which redirects to here:
https://keystatic.cloud/signup?from=team%2Fjoin%<signup_token>
Finally, if the use click "Password" to sign up with an email/password configuration, the page refreshes, clears the <signup_token>, and is redirected to:
https://keystatic.cloud/signup?with=password
I'd expect that the from query param is maintained with the appended with param. Example:
https://keystatic.cloud/signup?with=password&from=team%2Fjoin%<signup_token>
Adding the from param key and value back to the link allows the user to signup with association to the team and go directly into the verification process, which I assume is the happy path.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the /signin and /signup flow, especially the transition to /signup?with=password. Confirm where the from query parameter is dropped when Password is selected. Done means the signup URL preserves both with=password and the existing from value so team association and verification continue correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100