Thinkmill / Thinkmill/keystatic
widget field validation is not respected
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.4k
- Forks
- 159
- Avg merge
- 21h 41m
- Merged PRs (30d)
- 2
Description
when a custom richtext-field widget defines required fields in their schema, the validation is not respected and the document can be saved even when the required fields have not been filled out.
repro: https://github.com/stefanprobst/issue-keystatic-widget-field-validation
steps to reproduce:
- clone the above repo
- pnpm install && pnpm run dev
- open http://localhost:3000/keystatic
- create a new Post and add a "Widget" widget, without filling out anything, and click Save
- the document is saved even though the "Widget" has a required field in its schema:
https://github.com/stefanprobst/issue-keystatic-widget-field-validation/blob/fb9c2048134d1e9dc2e4eb9e81073cd786d56cfe/keystatic.config.tsx#L26
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue using the linked issue-keystatic-widget-field-validation repository: run pnpm install && pnpm run dev, open /keystatic, and save a Post containing an empty Widget. Start with keystatic.config.tsx around line 26, then trace the widget validation path. Done means saving is prevented when the required widget field is empty.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- content, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100