Thinkmill / Thinkmill/keystatic
Give groups a visual border
@jossmac is already working on this.
Since Sep 5, 2024.
- Dominant language
- TypeScript
- Stars
- 2.4k
- Forks
- 159
- Avg merge
- 21h 41m
- Merged PRs (30d)
- 2
Description
I want to revisit the idea to add a visual indication for groups.
(…) It lacks the prominent delineation of your example, which I'd like to revisit in the future. From memory we were concerned about introducing too much chrome, considering that objects may be infinitely nested.
Originally posted by @jossmac in https://github.com/Thinkmill/keystatic/issues/641#issuecomment-1749974974
| Current | Proposal |
|---|---|
From memory we were concerned about introducing too much chrome, considering that objects may be infinitely nested.
I expect the primary use case to have one group. So IMO the UI should serve this use case first. However, if deeply nested structures are in deed something that happens a lot and the border does indeed make this case noticably worse, we could add custom CSS to only show the border on the first level. Or introduce a new flag like showGrouped: true to opt into the border.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.