ThinkR-open / ThinkR-open/squash
clean_rendering_files() identifies files by name only, like the fixed copy-back bug
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 9
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Follow-up of #23. clean_rendering_files() computes setdiff(present_after, present_before) on file names only. A file that existed before rendering and was regenerated during it is treated as pre-existing and kept, while the same names-only identity caused the stale-output bug fixed in #23 for the copy-back side. Worth auditing under the same rule: snapshot (path, mtime, size) and decide explicitly what "created by rendering" means for modified files.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at clean_rendering_files() and read issue #23 for the related copy-back fix. Inspect how present_before and present_after are captured, then define how path, mtime, and size distinguish newly created from modified rendering outputs. Done means the cleanup behavior is explicit and covered by the repository’s relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100