ThinkR-open / ThinkR-open/squash
fix: `quiet` & `debug` should be forwarded as is to `render_single_qmd()` then `quarto_render()`
Open
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 9
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Description
quarto_render() has both debug & quiet, but these params are not forwarded from compile_qmd_course() and render_single_qmd():
This is the current logic:
- If
quietisFALSEincompile_qmd_course()then quiet is TRUE inquarto_render()
compile_qmd_course(quiet = FALSE, debug = FALSE)
# then
render_single_qmd(quiet = !debug) # TRUE
# then
quarto_render(quiet = TRUE)
- If
quietisTRUEincompile_qmd_course()then quiet is FALSE inquarto_render()
compile_qmd_course(quiet = TRUE, debug = TRUE)
# then
render_single_qmd(quiet = !debug) # FALSE
# then
quarto_render(quiet = FALSE)
This behavior makes it hard to reason about the function logic.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating compile_qmd_course(), render_single_qmd(), and quarto_render() and trace how quiet and debug are passed between them. Verify the corrected forwarding behavior for the combinations described in the issue, and confirm that the values received by quarto_render() match the values supplied to compile_qmd_course().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100