ThinkR-open / ThinkR-open/golem

`expect_running` either misleading or incorrectly passing

Open
#690 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
945
Forks
136
PR merge metrics
No merged PRs in 30d

Description

For reproduceable example:

golem::create_golem("test")
golem::use_recommended_tests()

Changed nothing but the app_server source,

app_server <- function( input, output, session ) {
  # Your application server logic 
  stop("")
}

The recommended test of expect_running passes in these conditions. Now this is either expected behaviour but misleading in the sense that the background R process may well be running but the shiny app itself is definitely not, or this is no the expected behaviour of the test.

My reprex package attached in zip
golem_expect_running.zip

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by unpacking the attached reprex and running the generated app with the shown app_server source. Inspect the recommended expect_running test entry point and reproduce the passing result when stop("") is called. Done means the test's behavior is clarified and covered by an appropriate regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.