ThinkR-open / ThinkR-open/golem
Deprecate {golem} JS built-in functions
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 945
- Forks
- 136
- PR merge metrics
- No merged PRs in 30d
Description
Following discussion with @daattali at #449 and now that {shinyjs} is under an MIT licence, there is no need to maintain built-in JavaScript functions in {golem}, so we'll remove them, and advice to switch for {shinyjs}.
We'll keep the add_js* file and invoke_js() mechanism, as I still think this is in {golem} scope to be able to provide tools for building JavaScript extension when you're comfortable doing it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the built-in JavaScript functions and the add_js* and invoke_js() mechanisms, then review the discussion in #449 and the shinyjs migration context. Done means the built-in functions and related advice are removed while add_js* and invoke_js() remain available for JavaScript extensions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, r
- Domain
- tooling, web-dev
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100