[Test] Add Step Boundary Range Assertion to Weekly Review Test Suite
Open
@logan-dev-x is already working on this.
Since Sep 19, 2026.
accessibility
area:core
beginner friendly
bug
community
contributions-welcome
difficulty:beginner
difficulty:easy
enhancement
good first issue
hacktoberfest
help wanted
testing
time:<15m
up-for-grabs
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 7
- Avg merge
- 39m
- Merged PRs (30d)
- 39
Description
- Labels:
good first issue,testing,difficulty:beginner,area:core - Target File:
tests/weekly-review.test.ts - Estimated Time: 15–20 minutes
- Difficulty: Level 3 (Beginner)
Why This Matters
The Weekly Review ritual progresses through 5 discrete steps (1: Retrospective, 2: Tasks Audit, 3: Habit Scorecard, 4: Goal Alignment, 5: Strategic Commitments). Boundary tests ensure invalid step indices (< 1 or > 5) are rejected cleanly.
Current Behavior
tests/weekly-review.test.ts validates standard step advancement, but does not explicitly assert that step indices 0 or 6 throw validation errors.
Requested Change
Add a dedicated test block in tests/weekly-review.test.ts asserting that step transitions clamp to valid range [1, 5].
Acceptance Criteria
- Boundary check test case added to
tests/weekly-review.test.ts. - Test executes and passes cleanly.
Verification
npm run test:file -- tests/weekly-review.test.ts
Contributor Notes
Self-contained unit test addition.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.