test: add boundary check test for weekly review step progression
Open
Beginner friendly
Nobody has claimed this yet.
area:testing
beginner friendly
community
contributions-welcome
difficulty:beginner
enhancement
good first issue
help wanted
type:test
up-for-grabs
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 7
- Avg merge
- 39m
- Merged PRs (30d)
- 39
Description
🎯 What needs to be done
In tests/weekly-review.test.ts, add a test case verifying that saveReviewDraftSchema rejects invalid step index values (e.g. step: 0 or step: 6).
Why this matters
Ensures user review drafts remain within the strict 5-step weekly review workflow boundaries.
📍 Where to work
tests/weekly-review.test.ts
🧭 Implementation guidance
- Open
tests/weekly-review.test.ts. - Locate the schema validation test suite.
- Add assertions testing
saveReviewDraftSchema.safeParsewithcurrent_step: 0andcurrent_step: 6to verify rejection. - Verify all tests pass.
✅ Acceptance criteria
- Boundary test added for weekly review draft step indices.
- All unit tests pass with 0 failures.
🧪 Verification
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open tests/weekly-review.test.ts and locate the schema validation test suite for saveReviewDraftSchema. Add safeParse assertions for current_step values 0 and 6, then run the unit tests; done means both invalid boundary values are rejected and all tests pass with zero failures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 92/100