ThePrimeagen / ThePrimeagen/init.lua
When two windows are open, only the current is highlighted and, I don't think, this is mentioend once.
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 4k
- Forks
- 680
- PR merge metrics
- No merged PRs in 30d
Description
Sorry if this is a silly issue but I can see how new users of neovim, (I know firsthand), would get confused about this.
In the ColorMyPencils function the highlight group set is the normal group, which doesn't include non-current windows. To include non-current windows, vim.api.nvim_set_hl(0, "NormalNC", {bg = none}) should also be set. The video makes it seem like the current colors.lua file re-colours all windows, but it doesn't. This stumped me, for a long time, and potentially other users so I thought it should be mentioned somewhere in this repo, in the comments of the 0 to lsp video, or in the description.
I'm not gonna tell ThePrimeagen how he should set his dotfiles, but I think he should have made it clear for people whose first neovim experience was that video the highlight group only includes the current window, instead of calling the normal highlight group "the thing this is just vim".
For people who combat this with "READ THE FUCKING MANUAL", I think you're partially right. This was a good learning experience for me and taught me about navigating documentation within vim and neovim. But, it also took me a long time scrubbing through my config looking for an error which could've been avoided, and I hope this issue can help other people like me who didn't know a thing about lua, or much about neovim.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ColorMyPencils function in the current colors.lua file and review the related 0 to lsp video context. Document that the normal highlight group applies only to the current window and explain how non-current windows are handled; the work is done when new users can find this clarification in the chosen comments or description.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100