The-Strategy-Unit / The-Strategy-Unit/tpma-explorer

Standardise the design/theming of the app

Open
#30 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement priority: should
Dominant language
R
Stars
0
Forks
2
Avg merge
1d 19h
Merged PRs (30d)
1

Description

Themes, font size, etc. What's the best way to control this? A _brand.yml maybe?

Also covers things like overlapping axes tick labels, which can be particularly bad on the x-axis of the trend chart (financial year). Note that that's a problem in the original chart code in nhp_inputs. We may be able to solve it here, package this code (https://github.com/The-Strategy-Unit/nhp_planning/issues/417) and use that package in nhp_inputs.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the proposed _brand.yml approach and the existing trend-chart implementation, including the financial-year x-axis labels. Check the related nhp_inputs issue and decide whether the chart solution belongs here or in a reusable package; done means an agreed theming approach and no overlapping tick labels.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization, design, frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.