The-Strategy-Unit / The-Strategy-Unit/nhp_model_databricks
Update methodology so that we keep provider information in IP and OP data
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 0
- Forks
- 1
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 1
Description
In order for inequalities methodology to work in PBM we need to keep provider in the IP and OP data, so we can join with the correct inequalities factors
We currently overwrite this (https://github.com/The-Strategy-Unit/nhp_model/blob/13c08ab3b398ca9579e54037cd9954f0f3f15ce5/src/nhp/model/data/databricks.py#L168-L169)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/nhp/model/data/databricks.py around lines 168-169 to understand where provider information is overwritten, then inspect the TODO in src/nhp/model/activity_resampling.py around lines 154-156. Trace provider information through the IP and OP data so it remains available for joining the correct inequalities factors; done means the TODO is resolved and the provider-specific join works in PBM.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- jupyter-notebook, python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100