The-Strategy-Unit / The-Strategy-Unit/nhp_model_databricks

Make check for full_model_results more robust

Open Beginner friendly
#25 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
0
Forks
1
Avg merge
1d 21h
Merged PRs (30d)
1

Description

Currently:

save_full_model_results = dbutils.widgets.get("save_full_model_results") == "True"

If someone (cough) enters "true" instead of "True" then it doesn't work. this isn't very user friendly. We could ensure that the left side is cast to lower?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the notebook code containing the save_full_model_results assignment and inspect how dbutils.widgets.get returns the value. Verify the change handles the casing described in the issue while preserving the existing "True" behavior; done means equivalent true/false inputs produce the expected setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook, python
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.