The-Strategy-Unit / The-Strategy-Unit/nhp_model_databricks

Fix TODO: full model results for national OP and A&E

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
0
Forks
1
Avg merge
1d 21h
Merged PRs (30d)
1

Description

https://github.com/The-Strategy-Unit/nhp_model_databricks/blob/0ce4fa9530ff4769bc959c4928f6676b92b42ed5/src/nhp/databricks/national.py#L110-L112

https://github.com/The-Strategy-Unit/nhp_model_databricks/blob/0ce4fa9530ff4769bc959c4928f6676b92b42ed5/src/nhp/databricks/national.py#L132-L134

I think we have resolved this more or less with this PR - just need to add the OP & A&E index columns to the Databricks model?

[@tomjemmett edit: transferred from nhp_model, updated links to points in code to be in this repo]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/nhp/databricks/national.py at lines 110-112 and 132-134, then compare the related nhp_model PR #235. Confirm how the Databricks model currently produces national results and whether the OP and A&E index columns are missing. Done means the full model results include those columns and the relevant behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.