The-Strategy-Unit / The-Strategy-Unit/nhp_model
dynamic versioning fails in the docker build process
Open
@tomjemmett is already working on this.
Since Jun 16, 2025.
priority: could
technical debt
- Dominant language
- Python
- Stars
- 18
- Forks
- 3
- Avg merge
- 21h 39m
- Merged PRs (30d)
- 10
Description
in #403 introduced https://github.com/The-Strategy-Unit/nhp_model/blob/9a5792b58613c00ec621f2a06e426253eb9fb7e0/Dockerfile#L25
the way dynamic versioning works with setuptools-scm requires the .git folder to be present so it picks up tags/commits. we aren't copying in the .git folder, so dynamic versioning fails.
this forces the version in the container to be v0.0.0, that is fine for now
a better solution might be to build the whl and copy that in, installing it instead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.