The-Strategy-Unit / The-Strategy-Unit/nhp_inputs
Update NDG structure in `default_params.json`?
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 2
- Forks
- 1
- Avg merge
- 15h 39m
- Merged PRs (30d)
- 6
Description
Observation: should the default_params.json have an updated structure for non-demographic variants?
We added an upgrade step in #424. Doesn't look like default params file changed. Should it have been? New params files do come out as expected though.
Current in params.json (simple single-level structure):
"non-demographic_adjustment": {
"ip": {},
"op": {},
"aae": {}
},
What the params.json looks like after passing though inputs (example):
"non-demographic_adjustment": {
"variant": "variant_2",
"value-type": "year-on-year-growth",
"values": {
"aae": {
"ambulance": [1.0121, 1.0142],
"walk-in": [1.0121, 1.0142]
},
"ip": {
"elective": [1.0053, 1.0071],
"maternity": [1, 1],
"non-elective": [0.9955, 1.0017]
},
"op": {
"first": [1.0228, 1.027],
"followup": [1.0228, 1.027],
"procedure": [1.0228, 1.027]
}
}
},
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the upgrade step from #424 and comparing it with default_params.json, especially the non-demographic_adjustment section. Check whether the default file should use the same structure shown in the generated params.json example; done means the expected default structure is established and the input flow remains valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100