The-Strategy-Unit / The-Strategy-Unit/nhp_inputs
Consider adding top-level structure to params
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 2
- Forks
- 1
- Avg merge
- 15h 39m
- Merged PRs (30d)
- 6
Description
We could split the params into two sections (or two separate files): 'metadata' and 'values' (or other, better names).
Partly for organisational sense (easier to identify what is metadata vs what is user-selection).
But also this would help solve the 'top-level empty dict' problem that R seems to have (was a problem in the v3.5 release, but being fixed separately in #485), where top-level empty keys were removed before POSTing. If we had top-levels of metadata and values then inequalities would no longer be top-level and would not get removed.
Obviously the model and schema would have to adapt to this new structure, as well as other products.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the current model and schema for params, then trace how the structure is serialized before POSTing. Compare the affected structure with the separate fix in #485 and inspect the other products that consume it; done means the new metadata and values structure, naming, schema, model, and consumers are agreed and updated consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100