The-Strategy-Unit / The-Strategy-Unit/nhp_inputs
Upgrade scenarios in the main app, not the selection app?
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 2
- Forks
- 1
- Avg merge
- 15h 39m
- Merged PRs (30d)
- 6
Description
Old scenarios get upgraded in the inputs selection app. This is done by assigning the model-version string as a class and then applying methods against that class. The class is then updated to the next model-version number and new methods are applied. And so on.
Dev runs do not get an app_version in params though, they just get the string 'dev'. Therefore they don't get upgraded and it borks the app.
As @tomjemmett points out:
so far all our changes to the params over time have been quite simple upgrades from a->b. Might there ever be a case where that isnt true?
I suspect the issue here is that dev scenarios don’t upgrade, so they have the wrong ndg values now
So my thought is: should the parameter upgrading be in the inputs app rather than the selection app?
Should the dev version be something more like app_version = vX.Y.Z, but have a is_dev: true flag
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare where scenario parameter upgrades run in the inputs selection app versus the main inputs app, starting with the app_version handling described in the issue. Reproduce a dev scenario using app_version 'dev', then determine how it should receive the same parameter upgrades while preserving a development flag; done means dev scenarios no longer fail because their ndg values are outdated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100