The-Strategy-Unit / The-Strategy-Unit/nhp_inputs

Correct variables to be reactives/non-reactives

Open
#396 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

should techdebt
Dominant language
R
Stars
2
Forks
1
Avg merge
15h 39m
Merged PRs (30d)
6

Description

Some variables would be better suited as reactives, or not. See app_server.R and mod_mitigators_server.R. These were flagged in the review of #377 (comments hidden).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading app_server.R and mod_mitigators_server.R, then inspect the review context from issue #377 if it is available. Identify the variables flagged there and determine which should be reactive or non-reactive; done means those variables have the appropriate reactive status in both files.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.