The-Strategy-Unit / The-Strategy-Unit/nhp_inputs
Simplify relative/absolute treatment given removal of functionality
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 2
- Forks
- 1
- Avg merge
- 15h 39m
- Merged PRs (30d)
- 6
Description
As suggested in https://github.com/The-Strategy-Unit/nhp_inputs/pull/372#discussion_r1941968144.
Originally, the prediction-interval slider could be switched between 'absolute' and 'relative', but we removed this because of a bug. Instead, the absolute values are shown under the slider. Originally, the single function update_slider() handled absolute and relative conversions, but the function won't exist anymore after #372. As such, we could rethink the param_conversion approach in future.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the discussion in pull request #372 and trace the remaining uses of param_conversion after update_slider is removed. Define the simplified treatment for the slider and its displayed absolute values, then confirm the obsolete absolute/relative conversion path is no longer required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100