The-Strategy-Unit / The-Strategy-Unit/TPMAs

Change how we handle creation/deprecation fields

Open
#20 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement priority: should
Dominant language
No language data
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

TPMA creation and deprecation are described by the active_from and active_to fields in the main lookup. These can be used to filter down from the full set of every TPMAs that ever existed.

But the values in these columns are NHP demand-model release versions. TPMAs existing beyond NHP now; we probably shouldn't tie these to core NHP functionality.

Suggestion:

  1. Extract the active_from and active_to fields (containing NHP model versions) into their own separate lookup (with tpma_code as the unique joining key).
  2. Use dates as values for the active_from and active_to fields. This still allows filtering for currently-active TPMAs.
  3. Introduce a changelog. This could be as simple as tpma_code, date, description to explain a change that didn't warrant a new TPMA code. This could be used downstream by e.g. tpma-explorer.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the main lookup and the current active_from and active_to fields, then review the linked tpma-explorer issue for downstream expectations. Done means the NHP-version fields are separated into a lookup keyed by tpma_code, active dates support filtering, and a changelog records relevant changes.

Written by the indexing model from the issue text.

Assessment

Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.