The-OpenROAD-Project / The-OpenROAD-Project/OpenSTA

Q: no omp header included, yet depending :opensta_lib depends on @openmp ?

Open Beginner friendly
#364 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Verilog
Stars
619
Forks
270
Avg merge
5d 15h
Merged PRs (30d)
4

Description

Looking at the sources, none includes an omp.h or omp-tools.h header:

rg "include.*omp.*\.h"

Yet the bazel library :opensta_lib depends on @openmp

https://github.com/The-OpenROAD-Project/OpenSTA/blob/8575070292cd0eb0150d191795ba59ca7e610ec2/BUILD#L400

.. and sets the -fopenmp option:

https://github.com/The-OpenROAD-Project/OpenSTA/blob/8575070292cd0eb0150d191795ba59ca7e610ec2/BUILD#L379

Is this intentional or some left-over from earlier versions ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced BUILD file lines 379 and 400, then run the reported ripgrep command to confirm whether any source includes OpenMP headers. Check whether the @openmp dependency and -fopenmp option are required by the current sources; done means removing unnecessary configuration or documenting why it remains.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.