The-OpenROAD-Project / The-OpenROAD-Project/OpenROAD
DRT: PA via candidates importance cohesion
@bnmfw is already working on this.
Since Jul 17, 2026.
- Dominant language
- Verilog
- Stars
- 3.1k
- Forks
- 1k
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 136
Description
Description
During Pin Access both filterViaAccess and genAPEnclosedBoundary functions share a bit of logic. Both functions know that the first two vias on the via_def list are more important than the others and should be used to create access coordinates and check for ap validity. However, they do not source this list from anywhere, they generate it, on the go, and use them, which seems inappropriate. If they were to get different lists, the code would work as usual, and no bugs would be raised, but it is very clear both functions are interested into answering the same questions "Which are the most important vias on this layer?".
Suggested Solution
Implement a single function called by both of the aforementioned function which is explicitly responsible for returning this list of via defs.
Additional Context
This issue was raised in the context of PR #9218.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.