Tensegritics / Tensegritics/ClojureDart

`emit-new` as a special case of `emit-dot`

Open
#58 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement tech-debt
Dominant language
Clojure
Stars
1.6k
Forks
119
PR merge metrics
No merged PRs in 30d

Description

In the wake of #52 and of the failed attempt at #53 (currently quick fixed), I came to the conclusion that emit-new as a special case of emit-dot. However my first attempt at merging them failed. I stumbled on several edge cases that we rely on -- leftovers from more lenient times.

I stumbled on issue with some types being emitted as (dart/type type-map) instead of just type-map, or even sometimes ^{:dart/type type-map} sym. It's a first incoherence.

I stumbled on errors with protocols being almost types but having dash in them (and yes (My-Record.) works in Clojure. So fixing constructor lookup for records is required.

Issues with members being missing during host-eval (especially on IProtocol).

A nice ball of hair to entangle.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the emit-new and emit-dot entry points and reproduce the type-emission, dashed-protocol, record-constructor, and host-eval member cases described in the issue. Done means these cases work consistently when emit-new is treated as a special case of emit-dot, including constructor lookup and IProtocol members.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure, dart
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.