Tensegritics / Tensegritics/ClojureDart

Potential regression from `lazy-seq` seq caching fix

Open
#345 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
1.6k
Forks
119
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/Tensegritics/ClojureDart/pull/322 I proposed a fix to lazy-seq not caching calls to seq.

When tried in ClojureScript a regression was found, as it made LazySeq less lazy: https://clojure.atlassian.net/browse/CLJS-3420

We should consider reverting https://github.com/Tensegritics/ClojureDart/pull/322 and find another fix. I made a suggestion to try in the Jira ticket, which also includes a regression test.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading pull request 322 and the linked CLJS-3420 Jira ticket, including its regression test and proposed alternative. Determine whether reverting the caching fix preserves the expected lazy-seq behavior, then validate the replacement or rollback against the regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure, dart
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.