Tensegritics / Tensegritics/ClojureDart

`this` members are not always properly inferred

Open
#255 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Clojure
Stars
1.6k
Forks
119
PR merge metrics
No merged PRs in 30d

Description

In Flutter 3.10.5 I add a def type with

  :extends m/RenderBox
  ^:mixin m/SlottedContainerRenderObjectMixin

which I upgraded in 3.13 to

  :extends m/RenderBox
  ^:mixin #/(m/SlottedContainerRenderObjectMixin dynamic m/RenderBox)

but then (.-constraints this) stopped being properly inferred as a BoxContraints (as per m/RenderBox) but as a Constraints (as per the mixin basis: m/RenderObject).

It may be a case of "first match wins" when walking the hierarchy or of traversal order -- ion which case we should triple check the canonical order in the Dart spec

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the two declaration forms from the issue in Flutter 3.10.5 and 3.13, then trace the type-inference path for (.-constraints this) and compare the hierarchy traversal order. Done means the member is inferred as BoxConstraints from RenderBox in the upgraded form, with regression coverage for the reported case.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure, dart, flutter
Domain
compilers, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.