Tensegritics / Tensegritics/ClojureDart
Add support for :extend-via-metadata in protocol definitions
Open
Nobody has claimed this yet.
enhancement
good first issue
- Dominant language
- Clojure
- Stars
- 1.6k
- Forks
- 119
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
Code can not be compiled once defprotocol elect to be extended via per-value metadata.
To Reproduce
Steps to reproduce the behavior:
- Create a CLJD project
- Try to compile this code:
(defprotocol MyProtocol :extend-via-metadata true
(some-fn [this]))
- See error
Don't know how to create ISeq from: clojure.lang.Keyword
Faulty form (defprotocol MyProtocol :extend-via-metadata true (some-fn [this]))
Expected behavior
- code can be compiled and metadata + protocols can be used.
Additional context
- I have experienced this error when trying to use Honey.SQL in CLJD
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported defprotocol form in a CLJD project and follow the compiler path that handles protocol definitions and the :extend-via-metadata option. Done means the form compiles without the reported ISeq error and metadata-based protocol use works as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- clojure, dart
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100