Tencent / Tencent/tdesign-react

[Table] Props.Loading建议与Card保持一致行为

Open
#3,309 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

💪🏻 enhancement 💭 discussion
Dominant language
TypeScript
Stars
965
Forks
373
Avg merge
3d 6h
Merged PRs (30d)
17

Description

这个功能解决了什么问题

props.loading 为TNode时, 与Card组件表现不一致, Table组件中只是作为 Loading.text的透传, 而Card组件可以完全覆盖默认

你建议的方案是什么

建议采用Card.loading的处理方式。 在需要自定义组件时有直接覆盖的途径,而不是通过loadingProps透传给默认的Loading

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the Table and Card loading entry points, focusing on how a TNode passed through loading is handled. Confirm that Table can directly override the default Loading component in the same way as Card, rather than only forwarding the value through Loading.text or loadingProps. Done means the two components have consistent custom Loading behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.