ArgMaxLayer, if(out_max_val == true) should output index first and then output max value
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 23.8k
- Forks
- 4.5k
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 37
Description
if (out_max_val)
{
float* valptr = outptr + topk;
for (int i=0; i<topk; i++)
{
**outptr[i] = vec[i].first; ---> outptr[i] = vec[i].second
valptr[i] = vec[i].second; ---> valptr[i] = vec[i].first**
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate ArgMaxLayer and the if (out_max_val) block shown in the report. Confirm the requested index-first, maximum-value-second output order, make the small correction, and run the relevant existing checks to verify the layer's output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100