TelegramMessenger / TelegramMessenger/Telegram-iOS
NSFW channels pinning in unread
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 9k
- Forks
- 2.9k
- PR merge metrics
- No merged PRs in 30d
Description
Checklist
- I am reporting an issue in existing functionality that does not work as intended
- I've searched for existing GitHub issues
Description
Now, when folders finally arrived, I took advantage of it and it's pretty nice.
Besides just one little thing.
I have a channel considered to be "NSFW" on iOS(works okay with desktops),
which from time to time obviously has new posts. Thus it gets into my "Unread" folder.
Once instead of swiping to mark it as "read"(since I can't read it anyway thanks to Apple),
I managed to press "Pin" button instead. No big deal I thought, but unpinning it actually keeps it in the folder anyway.
All the time. And on desktop it isn't shown in the folder if it is "read".
That's pretty annoying.
Expected Behavior
Any pinned channel in "Unread" folder can be unpinned which leads to its disappearance from the folder until unread messages arrive again(if there's none).
Actual Behavior
I believe that non-NSFW channels work fine,
but NSFW definitely got stuck without any proper way of resolving the issue
Steps to Reproduce
- Join via another platform any channel that is considered as NSFW by Apple
- Wait for new messages on it
- On iOS client went to "Unread" folder
- Pin the NSFW channel
- Unpin it
- Read the channel by swipe action
Environment
Device: iPhone SE(1st generation)
iOS version: 14.0.1
App version: 7.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue through the Unread folder and the channel pin/unpin flow on the stated iPhone SE and iOS 14.0.1 environment. Trace how unread status and pinned state are combined for NSFW channels, then verify that unpinning and reading the channel removes it until new messages arrive.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100