TelegramMessenger / TelegramMessenger/Telegram-iOS
Share Sheet suggestions stop working when Passcode set
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 9k
- Forks
- 2.9k
- PR merge metrics
- No merged PRs in 30d
Description
Checklist
- I am reporting an issue in existing functionality that does not work as intended
- I've searched for existing GitHub issues
Description
The issue is with Share Sheet suggestions which are frequent chats appearing in the top row of iOS sharing dialog: they stop working when enabling Telegram app Passcode.
Expected Behavior
Share Sheet suggests frequent chats event when Passcode is set.
Actual Behavior
When app-launch Passcode is enabled, Share Sheet suggestions either stop accumulating (always displays the same set of chats as before enabling Passcode), or is cleared and doesn't display any chats at all. I'm getting either one of these when trying to reproduce.
Steps to Reproduce
-
Have suggestions enabled: Settings → Data and Storage → Share Sheet → enable all switches, choose "All Sent Messages"
-
Have passcode disabled: Settings → Privacy and Security → Passcode & Touch ID → Turn Passcode Off
-
Reset suggestions: Settings → Data and Storage → Share Sheet → Reset All Share Suggestions
-
Send a message to any chat
-
Invoke a share sheet (e.g. by taking a screenshot and pressing share button). The chat should appear in the suggestions
-
Enable passcode: Settings → Privacy and Security → Passcode & Touch ID → Turn Passcode On
-
Send a message to another chat
-
Invoke a share sheet (e.g. by taking a screenshot and pressing share button). The new chat isn't there
Environment
Device: iPhone SE (2020)
iOS version: 13.4.1
App version: 6.1 (16973)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Share Sheet flow through Settings → Data and Storage → Share Sheet with the passcode enabled, following the listed message and share-sheet steps. Done means newly used chats continue appearing in Share Sheet suggestions after Passcode is turned on, rather than suggestions remaining unchanged or empty.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100