TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

Allow MC_GET_SHOP_ITEM_PRICE overwrite devil deal price and expose number of restock count buys if possible

Open
#810 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

callback request enhancement
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

Callback does modify money price but when trying to set a devil deal price it automatically snaps to recalculated vanilla one. Also would be nice for amount of restock buys for that item in order to account for new price. And if possible allow return table that contains new price and new restock count.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the MC_GET_SHOP_ITEM_PRICE callback entry point and trace how devil-deal prices and restock counts are currently calculated. Determine the supported callback result shape and verify that an override can control the price while exposing the restock-buy count; done means the requested values are applied consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, lua
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.