TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

`ModCallbacks.MC_PRE/POST_STATUS_EFFECT_APPLY` still triggers even when the player is immune to status effects

Open
#807 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

Evil Charm prevents certain status effects from affecting the player, yet this callback still triggers, I'm not sure if this behaviour is intended.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how ModCallbacks.MC_PRE/POST_STATUS_EFFECT_APPLY is dispatched and where Evil Charm immunity is checked. Determine the intended callback behavior for immune players, then verify that the callback and status-effect outcome are consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, lua
Domain
api, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.