TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

(Feature Request): Ability to set a consumable's pickup and drop sounds in pocketitems.xml

Open
#795 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement non-callback-request xml
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

Would be most useful for "object" type consumables, since they use the same pickup sound as cards by default, but currently would need to be manually replaced. Since xml sound attributes were recently added to the player, I figured why not consumables too

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with pocketitems.xml and trace how the recently added player XML sound attributes are parsed and applied. Extend the corresponding consumable handling so object-type consumables can define pickup and drop sounds, then verify that configured sounds replace the defaults in-game.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, xml
Domain
game-dev, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.