TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

Add 'Volume' float variable to PlayJingle() function

Open
#763 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement non-callback-request
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

would be helpful to be able to control the volume

especially with the soundtrack menu since it has a mode where room music is played as a 'jingle' to not interrupt the floor music

with jingles using SFX volume if someone has very different music and SFX volume settings the room music volume will be way off compared to the floor music

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the PlayJingle() entry point and tracing how the soundtrack menu invokes it for room music. Done means the function accepts a volume value and the jingle volume can be controlled independently of the SFX volume setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.