TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

Make EntityPlayer:AddLocust() return a table of EntityFamiliars

Open
#673 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement non-callback-request
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

EntityPlayer:AddWisp() in the base api returns EntityFamiliar, so we can easily edit the spawned wisp. I would like us to be able to do the same with EntityPlayer:AddLocust(), however I think it should return a table of EntityFamiliars, for better compatibility with items that spawn multiple locusts (e.g. inner eye), but if you are able to make other familiar spawning functions return EntityFamiliar, like EntityPlayer:SpawnBloodClot(), or EntityPlayer:AddLeprosy() then that would be appreciated.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementations of EntityPlayer:AddLocust(), EntityPlayer:AddWisp(), EntityPlayer:SpawnBloodClot(), and EntityPlayer:AddLeprosy(), and compare their return behavior. Done means AddLocust() exposes all spawned locusts as EntityFamiliars, with any additional familiar-spawning return changes covered consistently where feasible.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, lua
Domain
api, game-dev, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.