TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
GetTrinketsList and GetNullItemsList
Open
Nobody has claimed this yet.
non-callback-request
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
I'm making a funny thing, and I wanted to suggest two new functions for the EntityPlayer class:
-
GetTrinketsList(includeGolden: boolean)- Returns a list of all the trinkets the player has, similar to GetCollectiblesList().
- Returns 2 per golden trinket for the count if
includeGoldenis set to true.
-
GetNullItemsList()- Returns a list of all the null items the player has, similar to GetCollectiblesList()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the EntityPlayer class and the existing GetCollectiblesList() implementation. Use that behavior as the reference for the two requested lists, including the doubled count for golden trinkets. Done means both functions are available with the stated return contents and includeGolden behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100