TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

When using mouse controls to shoot, pressing LMB does not trigger IsActionTriggered() or IsActionPressed() for shoot actions (Opinions?)

Open
#595 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

If you play Isaac with mouse controls, you can use LMB to shoot. And while, for instance, pressing LMB below the character makes him shoot downwards, it does not trigger IsActionTriggered() nor IsActionPressed() for ButtonAction.ACTION_SHOOTDOWN.

Currently REPENTOGON does not change that behaviour, but I want to hear your opinions - should it stay that way or should it be changed? Personally I consider the base API implementation unreasonable.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how mouse controls map LMB input to ButtonAction.ACTION_SHOOTDOWN and where IsActionTriggered() and IsActionPressed() are evaluated. Compare the current REPENTOGON behavior with the base API, then establish the intended behavior before changing it; done means the decision is documented and the relevant action queries consistently match mouse shooting.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, game-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.