TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
More args for `MC_PRE_RENDER_ENTITY_LIGHTING`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
MC_PRE_RENDER_ENTITY_LIGHTING is a very handy callback, sadly right now with very little amount of things you can do with it, you can completely stop the rendering of the light, which is nice, you can change the offset, which could get handy, but there are a few things you cannot do which would be very useful, such as:
- Changing the color of the light
- Changing the size of the light
- Changing the variant of the light (which is based on its anm2 frame)
These are the main things I think this callback should also provide and grant the ability to change, maybe with a table as a return param, similar to TakeDamage callbacks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the MC_PRE_RENDER_ENTITY_LIGHTING callback and reviewing its current arguments and return behavior. Determine how color, size, and the anm2-frame-based variant should be exposed, then add coverage for the new callback behavior. Done means mods can change each requested light property without breaking existing callback usage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, lua
- Domain
- api, tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100