TeamREPENTOGON / TeamREPENTOGON/REPENTOGON
`ModCallbacks.MC_PLAYER_GET_HEART_LIMIT` bugs
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 345
- Forks
- 51
- Avg merge
- 11h 2m
- Merged PRs (30d)
- 4
Description
If you have two of these callbacks in a mod and both return a value, only the first callback gets run.
Example:
- A character with a health limit of 8 heart containers
- An item that adds 4 to the health limit while held
If you have this behaviour in separate callbacks (for organization maybe), only the first one will run.
It doesn't interact well with broken hearts, they can overflow, Heartbreak completely breaks this callbacks which makes characters invincible.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No implementation file or test is named. Start by locating the ModCallbacks.MC_PLAYER_GET_HEART_LIMIT dispatch, then reproduce separate callbacks, broken hearts, and Heartbreak cases; done means the callback behavior is correct for all three scenarios without overflow or invincibility.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- devtools, game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100