TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

TriggerWindowResize don't work properly

Open
#575 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

TriggerWindowResize don't work properly. I see only the lower part of the screen with different MaxScale, the rest part is cut off by the top of the screen. Plus the camera view is too close. I found this bug using a mod that calls Set Max Scale. I use last version (1.0.12b).
On the screenshot a big room 2х2. MaxScale = 3.

I reproduced this issue via debug console:
lua Options.MaxScale = 1
lua Isaac.TriggerWindowResize()

I have:
Windows 11 23H2
Resolution: 3840 х 1080
GPU: AMD Radeon RX 5700
CPU: AMD Ryzen 3800X
image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with lua Options.MaxScale = 1 followed by lua Isaac.TriggerWindowResize() on the reported ultrawide setup, then trace the TriggerWindowResize and Options.MaxScale entry points. Done means resizing no longer cuts off the upper screen and the camera view remains correctly framed at different MaxScale values.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, lua
Domain
game-dev, reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.