TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

Undefined nodes on Items.xml create ghost custumes (fucks costume xmldata)

Open
#554 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug vanilla-tweaks xml
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

You are reading that correctly, theres a vanilla oddity that makes it so undefined nodes on items.xml create null costumes...which, ofc, are not accounted for in xmldata and offset everything potentially fucking some related repentogon functionality.
Granted, yes, we can wash our hands on this one to a degree because "that xml is not valid" but its so easy to fuck that we may need to look into it eventually. Also its worth investigating what other silly effects undefined nodes cause in other xmls.
As an example, in case I'm not being clear with whats an undefined node:

<items root="yadayada">
       <stinko name="garbage" />
</items>

On this case, the stinko node will create an empty null costume...for some reason.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the undefined-node example in Items.xml and tracing how it becomes a null costume in the XML data handling. Identify whether other XML inputs show similar effects; done means the behavior is understood and the resulting costume or related functionality is handled consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.