TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

Water Enablers/Disablers in Corpse fixes

Open
#528 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

non-callback-request vanilla-tweaks
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

  1. Using Water Enablers in Corpse will not force the CORPSE3 BackdropType as expected
    image

  2. Using Water Disablers in Corpse makes the room use the CORPSE3 BackdropType despite the CORPSE1/CORPSE2 backdrops being expected
    image

  3. The "blood leaking from door" effect in rooms adjacent to blood-flooded rooms in Corpse does not account for Water Enablers/Disablers in the neighboring rooms. This is because this effect likely checks for the RoomDescriptor.FLAG_FLOODED flag, which is what floors like Downpour, Flooded Caves, and Corpse set in rooms on floor entry to automatically flood those rooms when they are entered. Water Enablers also automatically flood layouts on room entry, but the game does not consider these layouts "flooded" when evaluating them from outside the room. This issue is probably a lot harder to fix relative to how noticeable it is and less of a priority than the first two.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the CORPSE backdrop selection and the handling of Water Enablers/Disablers, searching for CORPSE1, CORPSE2, CORPSE3, and RoomDescriptor.FLAG_FLOODED. Reproduce the two backdrop cases first, then inspect how the adjacent-room blood-leaking effect evaluates neighboring rooms. Done means the expected backdrop is selected in both cases and the neighboring effect accounts for water-enabled or water-disabled rooms.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev, reverse-engineering
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.