TeamREPENTOGON / TeamREPENTOGON/REPENTOGON

"Secrets" count on stats post-it includes mods

Open
#495 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
345
Forks
51
Avg merge
11h 2m
Merged PRs (30d)
4

Description

The current behaviour of the stats screen is to sum together the number of achievements from mods and vanilla.
image

In my opinion, it makes more sense to only display the vanilla count, as it is having the 637 vanilla achievements that changes the save slot icon, and it's more convenient for the count to reflect progress towards Dead God. Additionally, toggling mods with achievements will change the number of modded secrets, making that total less useful.

An alternative is to separate the counts, ie render both the vanilla and modded totals separated by a plus, or on separate lines (which requires extending the post-it).
Or, this could be turned into a setting (vanilla count only / modded count only / summed totals), but it feels significantly too niche to be one.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name an implementation file, test, or entry point. First locate the stats screen's post-it rendering and achievement-count calculation, then resolve whether the intended result is vanilla-only or separate totals; done means the displayed count matches the agreed behavior and no longer changes with enabled mod achievements.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.